Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: replace golang.org/x/exp with stdlib #960

Merged
merged 2 commits into from
Mar 11, 2024
Merged

deps: replace golang.org/x/exp with stdlib #960

merged 2 commits into from
Mar 11, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 8, 2024

Closes #959

@jar-b jar-b requested a review from a team as a code owner March 8, 2024 19:27
@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 8, 2024 •
edited
Loading

Will need to update go.mod to declare usage of Go 1.21.
Plus README.md.

@jar-b
Copy link
Member Author

jar-b commented Mar 8, 2024

My mistake - for some reason I had 1.20 in my head where these went into the standard library.

ewbankkit
ewbankkit approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit ea0dbb2 into main Mar 11, 2024
12 checks passed
@jar-b jar-b deleted the rm-golang.org/x/exp branch March 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove golang.org/x/exp dependency
2 participants
@jar-b @ewbankkit